fix(material/chips): strengthen edit/remove icons focus/hover styling #31759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adolgachev
added
Accessibility
adolgachev
requested review from
andrewseguin and
wagnermaciel
and removed request for
a team
|
Deployed dev-app for 1d5ca15 to: https://ng-dev-previews-comp--pr-angular-components-31759-dev-61xov1fi.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
|
Deployed docs-preview for 1d5ca15 to: https://ng-dev-previews-comp--pr-angular-components-31759-docs-6rzp9mji.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
adolgachev
force-pushed
the
chips-icon-focus
branch
2 times, most recently
from
070397b to
d0db71f
Compare
adolgachev
force-pushed
the
chips-icon-focus
branch
from
7192b37 to
1d5ca15
Compare
crisbeto
reviewed
Aug 25, 2025
crisbeto
approved these changes
Aug 25, 2025
adolgachev
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes b/286103414 by doubling the opacity of the edit and remove icons when they are focused and hovered, to provide more contrast against the chip which has the same opacity added on focus/hover.
Note: making the change in m3-chip to keep the stronger (calculated) opacity as replaceable while also using the same base opacity. Since the latter is a variable, had to use calc there as well.